Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport 2.28] Print the list of failed suites in verbose mode #6412

Merged
merged 1 commit into from
Oct 13, 2022
Merged

[backport 2.28] Print the list of failed suites in verbose mode #6412

merged 1 commit into from
Oct 13, 2022

Conversation

mpg
Copy link
Contributor

@mpg mpg commented Oct 12, 2022

This is the 2.28 backport of #6403

@mpg
Print the list of failed suites in verbose mode
3211bbb 
In verbose mode, the full output of each failing suite is printed out,
which for some suites runs in the 1000s of lines. If you didn't redirect
output to a file, this is a lot to scroll and can make it hard to
quickly identify which test suites failed.

So, let's print out that information at the end. This is useful
information for starting to figure out what went wrong.

Signed-off-by: Manuel Pégourié-Gonnard <[email protected]>
@mpg mpg added needs-review Every commit must be reviewed by at least two team members, size-s Estimated task size: small (~2d) single-reviewer This PR qualifies for having only one reviewer priority-medium Medium priority - this can be reviewed as time permits labels Oct 12, 2022
@mpg mpg self-assigned this Oct 12, 2022
@mpg mpg mentioned this pull request Oct 12, 2022
Merged
gilles-peskine-arm
gilles-peskine-arm approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gilles-peskine-arm gilles-peskine-arm added approved Design and code approved - may be waiting for CI or backports needs-ci Needs to pass CI tests and removed needs-review Every commit must be reviewed by at least two team members, labels Oct 12, 2022
@mpg mpg removed the needs-ci Needs to pass CI tests label Oct 13, 2022
@mpg mpg merged commit a129bab into Mbed-TLS:mbedtls-2.28 Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilles-peskine-arm gilles-peskine-arm gilles-peskine-arm approved these changes

Assignees

@mpg mpg

Labels
approved Design and code approved - may be waiting for CI or backports priority-medium Medium priority - this can be reviewed as time permits single-reviewer This PR qualifies for having only one reviewer size-s Estimated task size: small (~2d)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpg @gilles-peskine-arm